gerlowskija commented on code in PR #4899:
URL: https://github.com/apache/solr/pull/4899#discussion_r4468790904
##########
changelog/unreleased/fix-solr-18439.yml:
##########
@@ -0,0 +1,7 @@
+title: Fix v2 APIs that report failures via HTTP 200 instead of a proper error
status.
Review Comment:
[Q] Your PR description mentions that these APIs haven't been released yet
so a changelog isn't needed. Is that true?
[Q] We've tried pretty hard to have our v1 APIs rely on the v2 code "under
the hood", so I imagine a change here would impact both v1 and v2. Does this
PR really only impact the v2 APIs?
[0] If we keep this, I'd change the wording to be less about what you did
("Fix") and more about the value to users, e.g. "Replication and snapshot APIs
no longer incorrectly return 200 on some error cases"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
