Copilot commented on code in PR #881:
URL: https://github.com/apache/solr-operator/pull/881#discussion_r4473992091
##########
build/Dockerfile:
##########
@@ -58,6 +68,21 @@ RUN CGO_ENABLED=0 GIT_SHA="${GIT_SHA}" make
fetch-licenses-full build
# If there is another way to view these files, we can remove "debug-".
FROM gcr.io/distroless/static:debug-nonroot
+# Build args are scoped to a stage, so the ones used by the labels below must
be declared again here
+ARG GIT_SHA
+ARG VERSION
+ARG DOCS_VERSION=latest
Review Comment:
The release wizard's RC and final `docker buildx build` commands still pass
only `GIT_SHA`, so these newly added label args are unset for published images:
`org.opencontainers.image.version` becomes empty and
`org.opencontainers.image.documentation` falls back to `latest` even for a
released version. Please pass the release `VERSION` and the corresponding
`DOCS_VERSION` in both release build invocations (or otherwise derive them
before labeling).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
