dsmiley opened a new pull request, #5291: URL: https://github.com/apache/solr/pull/5291
https://issues.apache.org/jira/browse/SOLR-18621 Adds name/value varargs factories to SolrJ, mirroring `SolrTestCaseJ4.params`. - `SolrParams.of(String...)` returns unmodifiable params; `ModifiableSolrParams.of(String...)` returns modifiable params (plus `of()` and `of(String, String)` so every overload on the subclass returns the modifiable type). - Repeated names become multi-values; null name/value becomes empty string; an odd count throws `IllegalArgumentException`. - Existing `params(String...)` helpers (SolrTestCaseJ4, CollectionsHandler, CoreAdminHandler, SyncStrategy, StreamTool, SolrBenchState) delegate to the new method. Other callers are not migrated. - A literal `ModifiableSolrParams.of(null)` is now ambiguous; the one such test call is cast. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
