nick-boss-tech commented on PR #5279: URL: https://github.com/apache/solr/pull/5279#issuecomment-6652926248
🤖 *AI text below* 🤖 *(reviewed by Nick Shanin)* Hi @dsmiley, I prepared a follow-up at `78a9bef183e710833517a32c1691dfd2c2d9a7df` with four tests using subclasses outside the handler package. They cover index and query analyzer overrides, `showmatch`, and `analyzeValues` dispatch for field-name and field-type requests. The hook Javadocs clarify that overrides manage analyzers they create, including separate query selection for output and matching. Production behavior is unchanged. On Linux with seed `5279C0DE`, `FieldAnalysisRequestHandlerTest` passed (11 tests) and `DocumentAnalysisRequestHandlerTest` passed (6 tests). Tidy left the tree clean. `./gradlew check -x test` passed in a normal clone after Antora rejected the linked-worktree run at `buildLocalAntoraSite`. Three isolated hook-bypass mutations failed at the intended assertions: index selection and query output each produced 2 failures per class; query matching produced 1 failure per class. This is additional coverage for the extension API, not a claim of an existing production failure. [Diff from the PR head to the tested head](https://github.com/nick-boss-tech/solr/compare/fd033eb55a4eb7c4a5d8c626ad099dd8137098fb...78a9bef183e710833517a32c1691dfd2c2d9a7df) To take these commits from the current PR head without rewriting history: ```shell git fetch https://github.com/nick-boss-tech/solr pr-5279-analysis-extensibility-tests git merge --ff-only 78a9bef183e710833517a32c1691dfd2c2d9a7df ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
