epugh commented on code in PR #5110:
URL: https://github.com/apache/solr/pull/5110#discussion_r4482111017
##########
solr/api/src/java/org/apache/solr/client/api/endpoint/CoreApis.java:
##########
@@ -40,8 +40,12 @@ interface Create {
interface GetStatus {
@GET
- @Operation(summary = "Fetch status info for all cores hosted on this
node.", tags = "cores")
- CoreStatusResponse getAllCoreStatus(@QueryParam("indexInfo") Boolean
indexInfo)
+ @Operation(
+ summary =
+ "Fetch status info for all cores hosted on this node, or on other
live nodes when 'nodes' is set.",
+ tags = "cores")
+ CoreStatusResponse getAllCoreStatus(
+ @QueryParam("indexInfo") Boolean indexInfo, @QueryParam("nodes")
String nodes)
Review Comment:
just to make sure I'm keeping up... With the new `X-Solr-targetNode` we no
longer need or want the `nodes` param right? And it got added in this PR to
make some of the plumbing work, but wiht the new header, we can now remove that
plumbing, and that simplifies our V2 api as well...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
