sarkaramrit1993 commented on code in PR #5238:
URL: https://github.com/apache/solr/pull/5238#discussion_r4461378704
##########
solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java:
##########
@@ -67,6 +67,7 @@ public abstract class RequestHandlerBase
PermissionNameProvider {
public static final String REQUEST_CPU_TIMER_CONTEXT = "publishCpuTime";
+ private static final String DISPATCHED_HANDLER = "dispatchedHandler";
Review Comment:
Not quite. Ping hands the same `req` to `/select` through
[`core.execute`](https://github.com/apache/solr/blob/7f224be7ceca075106804df494468711454da23d/solr/core/src/java/org/apache/solr/handler/PingRequestHandler.java#L263)
on the same thread. No new `SolrRequestInfo` is pushed, so
[`isNestedRequest()`](https://github.com/apache/solr/blob/7f224be7ceca075106804df494468711454da23d/solr/core/src/java/org/apache/solr/request/SolrRequestInfo.java#L70)
is false for it. SearchHandler [checks
both](https://github.com/apache/solr/blob/7f224be7ceca075106804df494468711454da23d/solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java#L159-L166).
Dropping the [marker
check](https://github.com/apache/solr/blob/7f224be7ceca075106804df494468711454da23d/solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java#L416)
makes
[`testPingNotReported`](https://github.com/apache/solr/blob/7f224be7ceca075106804df494468711454da23d/solr/core/src/test/org/apache/solr/handler/component
/SearchRequestListenerTest.java#L403) fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
