janhoy commented on PR #887: URL: https://github.com/apache/solr-operator/pull/887#issuecomment-6727996225
PR updated with @dsmiley's latest improvements to the solr workflow. Tuned the assessments on some more read PRs. Here is the new output on the same PR #843 as below (table output): **Automated PR readiness judgements** (LLM-generated; may be wrong; not updated on later pushes). - ⚠️ [Operator chart changelog](https://github.com/apache/solr-operator/blob/main/helm/solr-operator/Chart.yaml) **— missing** (suggest added): The PR introduces a new opt-in external addressability method `Gateway` (new CRD fields in api/v1beta1/solrcloud_types.go) and new controller logic to manage HTTPRoute and BackendTLSPolicy resources, which is a new capability for users. - ✅ [Chart README values table](https://github.com/apache/solr-operator/blob/main/helm/solr-operator/README.md#chart-values): not needed <!-- The changes add RBAC rules to the Helm chart's role.yaml but do not add, rename, or change any Helm chart values in helm/solr-operator or helm/solr. --> - ✅ [User documentation](https://github.com/apache/solr-operator/tree/main/docs/modules): included <!-- New CRD fields (spec.solrAddressability.external.method=Gateway, spec.solrAddressability.external.gateway) and their behavior (HTTPRoute/BackendTLSPolicy management) are user-facing features that require documentation in docs/modules. --> - ⚠️ [Upgrade notes](https://github.com/apache/solr-operator/blob/main/docs/modules/upgrade-notes/pages/upgrade-notes.adoc) **— missing**: The operator requires new RBAC permissions for gateway.networking.k8s.io resources (httproutes, backendtlspolicies), which users managing RBAC themselves must add, and the PR upgrades dependencies (Go, Kubernetes libraries, controller-runtime) which may have implications for the operator's runtime environment. - ✅ [Tests](https://github.com/apache/solr-operator/blob/main/docs/modules/development/pages/development.adoc#testing): included <!-- The PR adds significant new Go logic in controllers/ (solr_gateway_util.go, gateway_util.go, gateway_util_backendtls.go) and modifies the reconciler, which warrants new or changed tests in the envtest unit tests or e2e tests. --> - ✅ [CRD option completeness](https://github.com/apache/solr-operator/blob/main/docs/modules/solr-cloud/pages/solr-cloud-crd.adoc): no concern <!-- The new CRD fields are wired through to the controllers (reconcileGatewayResources), have appropriate doc comments and kubebuilder markers, and use pointers where 'unset' vs 'zero' matters. The solr Helm chart does not need to expose this as it is a SolrCloud spec option, not a chart value. --> - ⚠️ [Version compatibility](https://github.com/apache/solr-operator/blob/main/docs/modules/upgrade-notes/pages/upgrade-notes.adoc#version-compatibility-matrixes) **— please check**: The PR requires Gateway API v1.4.0+ for BackendTLSPolicy GA support and upgrades to Go 1.24.0+ and Kubernetes libraries v0.34.1, which may not be available across the entire supported range (Kubernetes 1.22+). - ✅ Testing notes: no concern <!-- The PR description explicitly states that e2e tests were added (tests/e2e/solrcloud_gateway_test.go) and manual testing was performed with kgateway on Kubernetes 1.32, verifying backward compatibility and TLS backend connections. --> <!-- Assessed commit 3c472c71da7403522cb2c81d5ea96e09f5eb8b62 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
