janhoy opened a new pull request, #893: URL: https://github.com/apache/solr-operator/pull/893
🤖 AI assisted 🤖 Closes #867 **Problem.** Making one setting configurable is the most repeated change in this repo, and it is never a one-file change. #571 (`sessionAffinity`) touched 15 files; #790 (`enableServiceLinks`) touched 12. Both walked the identical path: the Go field and its kubebuilder markers, the plumbing into the generated objects, a controller test, the Helm value, the value's mapping template, the README values table, the chart changelog, and four regenerated files. The regenerated files are the easy part, because forgetting them fails `make check-manifests` immediately. The expensive mistakes are the ones CI is happy with. Skip the `_custom_option_helpers.tpl` mapping and the Helm value exists, is documented, and silently does nothing. Skip the README row and the value is undiscoverable. Skip the chart changelog and the release notes never mention the feature. Each is a few lines, each is invisible until a user hits it. **Solution.** `.agents/skills/add-crd-field/SKILL.md`, alongside `dependency-upgrade`, with a row added to the skills table in `AGENTS.md`. It opens with the three questions that decide the file set, because the answers branch it: which resources are in scope, whether the field is reachable from the Helm chart, and how the controller test validates it. Then the hand-written and generated file lists, the repo's conventions for a new field, the regeneration and verification commands, and what is out of scope. Worth noting one thing the skill gets right that the issue did not: the changelog convention is conditional, not fixed. A CRD change is announced in the operator chart (#790), but a change that only adds a chart value is announced in the solr chart (#811). Docs only, no code change. Every path, make target and command in the file was checked against the current tree, and claims that would rot quietly were rewritten to state the durable fact or the instruction that survives it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
