dsmiley commented on code in PR #5303: URL: https://github.com/apache/solr/pull/5303#discussion_r4520678516
########## changelog/unreleased/SOLR-18625-empty-phrase-boost-matchalldocs.yml: ########## @@ -0,0 +1,12 @@ +title: Fix the eDisMax parser adding an empty phrase field (pf) boost clause when no phrase qualifies + for the boost, such as for single-term queries or q=*:*, and an empty boost query (bq) clause when + the bq consists only of stopwords. The empty SHOULD clauses did not affect scoring but defeated the + single-clause MatchAllDocsQuery optimization; they are now omitted, so q=*:* reduces to a + MatchAllDocsQuery even when pf or bq is set. +type: fixed Review Comment: "defeating an optimization" doesn't sound like a user will experience this as a bug. I'm thinking "changed". WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
