[
https://issues.apache.org/jira/browse/SOLR-18637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-18637:
-------------------------------
Description:
SOLR-17774 renamed {{TracerConfigurator}} to {{OpenTelemetryConfigurator}} and
replaced {{getTracer()}}/{{getOpenTelemetrySdk()}} with
{{createOpenTelemetry()}}, but left two tracing-era names behind:
* the {{opentelemetry}} module's {{OtelTracerConfigurator}}
* the {{solr.xml}} {{<tracerConfig>}} element
Neither is tracing-only any more. The class bootstraps the autoconfigured SDK,
resolves the resource that traces and metrics share, and suppresses the SDK's
own metrics and logs pipelines. The ref guide currently just notes that the
names predate OpenTelemetry covering more than tracing.
Proposed:
* Rename the module class, keeping {{OtelTracerConfigurator}} as a deprecated
subclass so existing {{solr.xml}} keeps working.
* Accept {{<openTelemetryConfig>}} as an alias for {{<tracerConfig>}},
deprecating the latter.
* Update the {{solr.otelDefaultConfigurator}} default, the ref guide examples,
and the major-changes page.
Config-visible, so it needs a deprecation cycle with {{since}} set to the
landing release.
🤖 AI Assisted
was:
SOLR-17774 renamed {{TracerConfigurator}} to {{OpenTelemetryConfigurator}} and
replaced {{getTracer()}}/{{getOpenTelemetrySdk()}} with
{{createOpenTelemetry()}}, but left two tracing-era names behind:
* the {{opentelemetry}} module's {{OtelTracerConfigurator}}
* the {{solr.xml}} {{<tracerConfig>}} element
Neither is tracing-only any more. The class bootstraps the autoconfigured SDK,
resolves the resource that traces and metrics share, and suppresses the SDK's
own metrics and logs pipelines. The ref guide currently just notes that the
names predate OpenTelemetry covering more than tracing.
Proposed:
* Rename the module class, keeping {{OtelTracerConfigurator}} as a deprecated
subclass so existing {{solr.xml}} keeps working.
* Accept {{<openTelemetryConfig>}} as an alias for {{<tracerConfig>}},
deprecating the latter.
* Update the {{solr.otelDefaultConfigurator}} default, the ref guide examples,
and the major-changes page.
Config-visible, so it needs a deprecation cycle with {{since}} set to the
landing release.
> Rename OtelTracerConfigurator and <tracerConfig> to match OpenTelemetry's
> scope
> -------------------------------------------------------------------------------
>
> Key: SOLR-18637
> URL: https://issues.apache.org/jira/browse/SOLR-18637
> Project: Solr
> Issue Type: Improvement
> Components: metrics, tracing
> Reporter: Jan Høydahl
> Priority: Major
> Labels: otel
>
> SOLR-17774 renamed {{TracerConfigurator}} to {{OpenTelemetryConfigurator}}
> and replaced {{getTracer()}}/{{getOpenTelemetrySdk()}} with
> {{createOpenTelemetry()}}, but left two tracing-era names behind:
> * the {{opentelemetry}} module's {{OtelTracerConfigurator}}
> * the {{solr.xml}} {{<tracerConfig>}} element
> Neither is tracing-only any more. The class bootstraps the autoconfigured
> SDK, resolves the resource that traces and metrics share, and suppresses the
> SDK's own metrics and logs pipelines. The ref guide currently just notes that
> the names predate OpenTelemetry covering more than tracing.
> Proposed:
> * Rename the module class, keeping {{OtelTracerConfigurator}} as a deprecated
> subclass so existing {{solr.xml}} keeps working.
> * Accept {{<openTelemetryConfig>}} as an alias for {{<tracerConfig>}},
> deprecating the latter.
> * Update the {{solr.otelDefaultConfigurator}} default, the ref guide
> examples, and the major-changes page.
> Config-visible, so it needs a deprecation cycle with {{since}} set to the
> landing release.
> 🤖 AI Assisted
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
