github-actions[bot] commented on PR #5320: URL: https://github.com/apache/solr/pull/5320#issuecomment-6781519040
**Automated PR readiness judgements** (LLM-generated; may be wrong; not updated on later pushes). - ✅ [Jira issue in title](https://github.com/apache/solr/blob/main/CONTRIBUTING.md): already present - ⚠️ [Changelog](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc#_changelog_types_reference) **— differs from the entry** (suggest type: added; PR has type: changed): The PR introduces a new stable 'id' field for Rule-Based Authorization permissions and allows 'update-permission' and 'delete-permission' to accept this 'id' as an alternative to 'index'. This is a new feature/configuration capability that users must opt into by using the new parameter, fitting the 'added' category. - ✅ [Reference Guide update](https://github.com/apache/solr/tree/main/solr/solr-ref-guide): included <!-- The change adds a new 'id' field to the permission objects and a new 'id' parameter for the 'update-permission' and 'delete-permission' commands in the security API, which requires documentation in the Reference Guide. --> - ⚠️ [Upgrade notes](https://github.com/apache/solr/tree/main/solr/solr-ref-guide/modules/upgrade-notes/pages) **— probably not needed**: The change is backwards-compatible; the existing 'index' parameter continues to work, and the new 'id' is additive. No existing behavior is broken or removed. - ✅ Tests: included <!-- The PR modifies core security logic in 'AutorizationEditOperation.java' to handle ID generation, validation, and lookup, which is non-trivial production logic requiring tests to ensure correctness of the new ID-based operations and backfilling. --> <!-- Assessed commit 5fa5513038a7cf9318ed800423d8a44064d4c0e3 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
