epugh commented on code in PR #5306:
URL: https://github.com/apache/solr/pull/5306#discussion_r4539399078
##########
solr/packaging/build.gradle:
##########
@@ -365,13 +365,23 @@ abstract class BatsTask extends Exec {
@Optional
String filterTags = null
+ // Whether testFiles was populated via the --tests CLI option, as opposed to
being
+ // preconfigured by the build script (e.g. integrationTestsPicocli's curated
list).
+ // Explicitly requesting tests by name means the nightly tag filter should
not apply.
+ // TODO: once the commons-cli/picocli split goes away
(integrationTestsPicocli and its
+ // hardcoded testFiles list are removed), this field is redundant with
`!testFiles.empty`
+ // and can be deleted in favor of that simpler check.
+ @Input
+ boolean testsSelectedViaCli = false
Review Comment:
Also goes away when we get rid of commons clo and the filtering of tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
