nick-boss-tech commented on PR #5201: URL: https://github.com/apache/solr/pull/5201#issuecomment-6807653774
🤖 *AI text below* 🤖 *(reviewed by Nick Shanin)* Hi @epugh, I took a stab at the two issues. The [proposed changes](https://github.com/nick-boss-tech/solr/compare/3f9faa9e9861ce28f3ede3f4305bd91b6e297463...0355023c3170c87a84cd9e5688ae6b4f3e4df3ae) forward the current Admin UI credentials and `X-Requested-With` on same-origin Scalar requests, and add a browser test that sends a collections request and navigates back. If you would like to take them onto your branch, with your branch at `3f9faa9e9861ce28f3ede3f4305bd91b6e297463`: ```sh git switch api-explorer-demo git fetch https://github.com/nick-boss-tech/solr.git pr-5201-auth-browser-fix git merge --ff-only 0355023c3170c87a84cd9e5688ae6b4f3e4df3ae ``` On Linux at that head, the focused explorer test passed, as did the security and neighboring smoke tests (2 and 5 tests). Tidy made no changes, and the root check passed with only tests excluded. A packaged Basic Auth browser run loaded the explorer under the production framing policy, sent a successful collections request, and returned to the Admin UI. The unchanged new test reached the request and failed waiting for the response on the original PR head. JWT was not tested. One behavior to consider: after a password change, an explorer request receives 401 but does not itself clear the old credential or open login. The next Admin UI request triggers login, and the explorer works again after re-authentication. Would you want the explorer to trigger the same recovery directly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
