sijuv opened a new pull request, #5324:
URL: https://github.com/apache/solr/pull/5324

   …x lifetime in the Jetty SolrJ client
   
   Pooled connections were reused for as long as they stayed open: HTTP/2 was 
limited to 4 connections per destination and the client-level connection idle 
timeout was hard-coded to -1, so a degraded connection was never replaced short 
of restarting the client.
   
   Add three opt-in builder options, defaults unchanged:
   - withConnectionMaxDuration: sets AbstractConnectionPool.setMaxDuration on 
each destination's pool, so connections older than the duration are replaced 
(HTTP/1.1 and HTTP/2).
   - withMaxHttp2ConnectionsPerHost: number of HTTP/2 connections per 
destination (default 4). A separate option so clients tuning 
maxConnectionsPerHost for HTTP/1.1 keep their HTTP/2 behaviour.
   - withConnectionIdleTimeout: HttpClient idle timeout, which Jetty also 
applies to HTTP/2 sessions.
   
   All three are rejected together with withHttpClient(...).
   
   https://issues.apache.org/jira/browse/SOLR-XXXXX
   
   <!--
   _(If you are a project committer then you may remove some/all of the 
following template.)_
   
   Before creating a pull request, please file an issue in the ASF Jira system 
for Solr:
   
   * https://issues.apache.org/jira/projects/SOLR
   
   For something minor (i.e. that wouldn't be worth putting in release notes), 
you can skip JIRA.
   To create a Jira issue, you will need to create an account there first.
   
   The title of the PR should reference the Jira issue number in the form:
   
   * SOLR-####: <short description of problem or changes>
   
   SOLR must be fully capitalized. A short description helps people scanning 
pull requests for items they can work on.
   
   Properly referencing the issue in the title ensures that Jira is correctly 
updated with code review comments and commits. -->
   
   
   # Description
   
   Please provide a short description of the changes you're making with this 
pull request.
   
   # Solution
   
   Please provide a short description of the approach taken to implement your 
solution.
   We appreciate transparent disclosure of significant [AI Coding 
assistants](https://github.com/apache/solr/blob/main/dev-docs/how-to-contribute.adoc#setup-for-contributing)
 usage.
   
   # Tests
   
   Please describe the tests you've developed or run to confirm this patch 
implements the feature or solves the problem.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [ ] I have reviewed the guidelines for [How to 
Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my 
code conforms to the standards described there to the best of my ability.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to