epugh commented on code in PR #5325: URL: https://github.com/apache/solr/pull/5325#discussion_r4551535565
########## solr/bin/solr.cmd: ########## @@ -32,6 +32,10 @@ pushd %SOLR_TIP% set SOLR_TIP=%CD% popd +REM Where the per-node files recording running Solr instances live. Same variable and default as +REM bin/solr and as SolrProcessManager's solr.pid.dir. Review Comment: do we need the explanatory "Same variable and default as bin/solr and as SolrProcessManager's solr.pid.dir" line? I don't think we really do that for other variables? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
