janhoy commented on code in PR #5323:
URL: https://github.com/apache/solr/pull/5323#discussion_r4552756068


##########
solr/core/src/java/org/apache/solr/cli/SolrProcessManager.java:
##########
@@ -54,19 +54,37 @@ public class SolrProcessManager {
   // Set this to true during testing to allow the SolrProcessManager to find 
only mock Solr
   // processes
   public static boolean enableTestingMode = false;
+
+  /**
+   * System property ({@code solr.process.scan.marker}, or the {@code 
SOLR_PROCESS_SCAN_MARKER}

Review Comment:
   For sure, it's a generic marker, and we could now cut over use of the legacy 
`-DmockSolr=true` marker used in `SolrProcessManagerTest` to use the new 
generic marker. Good catch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to