github-actions[bot] commented on PR #4710: URL: https://github.com/apache/solr/pull/4710#issuecomment-6824503123
**Automated PR readiness judgements** (LLM-generated; may be wrong; not updated on later pushes). - ✅ [Jira issue in title](https://github.com/apache/solr/blob/main/CONTRIBUTING.md): already present - ✅ [Changelog](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc#_changelog_types_reference): type: fixed <!-- The change fixes a bug where `bin/solr.cmd start` on Windows would wait for all running Solr instances instead of just the one being started, and also fixes the connection host resolution to use the advertised or bind host instead of always localhost, which is a user-visible fix for SSL and non-loopback binds. --> - ⚠️ [Reference Guide update](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) **— probably not needed** (confidence: medium): The change modifies internal behavior of the CLI status tool and the Windows start script to correctly target the specific instance and resolve the correct host, but does not introduce new configuration options, parameters, or user-facing API changes that require Reference Guide documentation. - ✅ [Upgrade notes](https://github.com/apache/solr/tree/main/solr/solr-ref-guide/modules/upgrade-notes/pages): not needed <!-- The change is a bug fix that restores expected behavior (waiting for the specific instance and using the correct host) and does not remove or rename any parameters, APIs, or configuration elements, nor does it change defaults in a way that requires user action. --> - ✅ Tests: included <!-- The PR introduces new logic in `SolrProcessManager` for parsing system properties, resolving local connect hosts (including IPv6 and wildcard handling), and waiting for processes, as well as changes in `StatusTool` for timeout management, which are non-trivial production logic changes that warrant new or updated tests. --> <!-- Assessed commit 1d81010cba3175117bbf87933a26271dd1b81523 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
