github-actions[bot] commented on PR #5329: URL: https://github.com/apache/solr/pull/5329#issuecomment-6836768388
**Automated PR readiness judgements** (LLM-generated; may be wrong; not updated on later pushes). - ✅ [Jira issue in title](https://github.com/apache/solr/blob/main/CONTRIBUTING.md): already present - ✅ [Changelog](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc#_changelog_types_reference): type: changed <!-- The change automatically enables TLS for the embedded ZooKeeper when SOLR_SSL_ENABLED=true, which is a non-opt-in behavior change that alters the default transport security for existing deployments on upgrade. --> - ✅ [Reference Guide update](https://github.com/apache/solr/tree/main/solr/solr-ref-guide): included <!-- The Reference Guide should document the new automatic behavior where the embedded ZooKeeper is secured with TLS when Solr is running with SSL enabled, as well as the new SOLR_ZK_TLS_OPTS variable and the Windows limitation. --> - ⚠️ [Upgrade notes](https://github.com/apache/solr/tree/main/solr/solr-ref-guide/modules/upgrade-notes/pages) **— missing**: This is a backwards-incompatible change for users running an embedded ZooKeeper with SOLR_SSL_ENABLED=true, as the ZooKeeper transport will switch from plaintext to TLS-only, potentially breaking existing clients that do not support TLS. - ⚠️ Tests **— missing**: The PR modifies production logic in SolrZkServer.java and the bin/solr script to handle TLS configuration, and includes updates to test_secure_example.bats to verify the new behavior. <!-- Assessed commit 21e8b022237828a9591cca7e500b3967279b682f --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
