github-actions[bot] commented on PR #5329:
URL: https://github.com/apache/solr/pull/5329#issuecomment-6836768388

   **Automated PR readiness judgements** (LLM-generated; may be wrong; not 
updated on later pushes).
   
   - ✅ [Jira issue in 
title](https://github.com/apache/solr/blob/main/CONTRIBUTING.md): already 
present
   - ✅ 
[Changelog](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc#_changelog_types_reference):
 type: changed <!-- The change automatically enables TLS for the embedded 
ZooKeeper when SOLR&#95;SSL&#95;ENABLED&#61;true&#44; which is a 
non&#45;opt&#45;in behavior change that alters the default transport security 
for existing deployments on upgrade&#46;​ -->
   - ✅ [Reference Guide 
update](https://github.com/apache/solr/tree/main/solr/solr-ref-guide): included 
<!-- The Reference Guide should document the new automatic behavior where the 
embedded ZooKeeper is secured with TLS when Solr is running with SSL 
enabled&#44; as well as the new SOLR&#95;ZK&#95;TLS&#95;OPTS variable and the 
Windows limitation&#46;​ -->
   - ⚠️ [Upgrade 
notes](https://github.com/apache/solr/tree/main/solr/solr-ref-guide/modules/upgrade-notes/pages)
 **— missing**: This is a backwards&#45;incompatible change for users running 
an embedded ZooKeeper with SOLR&#95;SSL&#95;ENABLED&#61;true&#44; as the 
ZooKeeper transport will switch from plaintext to TLS&#45;only&#44; potentially 
breaking existing clients that do not support TLS&#46;​
   - ⚠️ Tests **— missing**: The PR modifies production logic in 
SolrZkServer&#46;​java and the bin&#47;​solr script to handle TLS 
configuration&#44; and includes updates to 
test&#95;secure&#95;example&#46;​bats to verify the new behavior&#46;​
   
   <!-- Assessed commit 21e8b022237828a9591cca7e500b3967279b682f -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to