sarkaramrit1993 commented on PR #5075:
URL: https://github.com/apache/solr/pull/5075#issuecomment-6840527088

   The comments and javadoc could be a lot leaner. Several explain the 
reasoning behind the change, which helps in review but goes stale in the code. 
Trimming them wherever possible would help. A few examples:
   
   - [`StreamingSolrClients` 
L55-L58](https://github.com/nick-boss-tech/solr/blob/f8d4bdbea518901e255ae119f3e5c43e7804a9bf/solr/core/src/java/org/apache/solr/update/StreamingSolrClients.java#L55-L58),
 4 lines → `// Maps each streamed UpdateRequest to its Req; entries leave when 
their stream completes.`
   - [`TolerantUpdateProcessor` 
L238-L241](https://github.com/nick-boss-tech/solr/blob/f8d4bdbea518901e255ae119f3e5c43e7804a9bf/solr/core/src/java/org/apache/solr/update/processor/TolerantUpdateProcessor.java#L238-L241),
 4 lines → `// Errors from one failed stream share an exception; count it once.`
   - [The comment inside the new `handleError` 
(L162-L164)](https://github.com/nick-boss-tech/solr/blob/f8d4bdbea518901e255ae119f3e5c43e7804a9bf/solr/core/src/java/org/apache/solr/update/StreamingSolrClients.java#L162-L164)
 can go, since the loop already says it.
   
   Also, [the javadoc on `handleError(Throwable, List, List, 
String)`](https://github.com/nick-boss-tech/solr/blob/f8d4bdbea518901e255ae119f3e5c43e7804a9bf/solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateBaseSolrClient.java#L666-L667)
 says the default behaves exactly like `handleError(Throwable)`. With an 
`UpdateErrorHandler` registered, the failure goes to that handler instead.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to