github-actions[bot] commented on PR #5337: URL: https://github.com/apache/solr/pull/5337#issuecomment-6863209436
**Automated PR readiness judgements** (LLM-generated; may be wrong; not updated on later pushes). - ✅ [Jira issue in title](https://github.com/apache/solr/blob/main/CONTRIBUTING.md): already present - ⚠️ [Changelog](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc#_changelog_types_reference) **— missing** (suggest type: fixed): The PR fixes incorrect exit codes for the Solr CLI (e.g., `solr --help` exiting 1 instead of 0, and missing subcommands exiting 0 or 1 instead of 2), which are user-visible bugs in the command-line interface. - ✅ [Reference Guide update](https://github.com/apache/solr/tree/main/solr/solr-ref-guide): not needed <!-- While the Reference Guide documents CLI usage, it typically does not specify exact exit codes for error states or help commands, so this behavioral fix likely does not require a documentation update. --> - ✅ [Upgrade notes](https://github.com/apache/solr/tree/main/solr/solr-ref-guide/modules/upgrade-notes/pages): not needed <!-- The change corrects exit codes to standard conventions (0 for success/help, 2 for usage errors) and does not remove or rename any parameters, APIs, or configuration elements that would require user action during an upgrade. --> - ✅ Tests: included <!-- The PR modifies production logic in `SolrCLI.java` and related tool classes to change exit code behavior, which warrants new or updated tests to verify the correct exit codes for various CLI invocations. --> <!-- Assessed commit 86d78688654e92293f7687d642e92b4ce557524e --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
