janhoy opened a new pull request, #5343:
URL: https://github.com/apache/solr/pull/5343
🤖 Follow-up to #5335, which removed the last commented-out `@BadApple`
annotations. This removes the other half: the build plumbing that still
advertised and forwarded a `tests.badapples` flag for an annotation that no
longer exists.
- `gradle/testing/randomization.gradle`: drop the `tests.badapples`
test-option declaration, so it no longer shows up in `./gradlew testOpts` /
`helpTests` as a supported knob.
- `dev-tools/`: drop the `-Dtests.badapples=false` that
`buildAndPushRelease.py`, `smokeTestRelease.py` and
`lucene-solr-yetus-personality.sh` still passed to Gradle.
`-Dtests.nightly=false` stays — that annotation is real.
Evidence the flag is dead:
- `@BadApple` is gone from Lucene's test framework.
`lucene-test-framework-10.4.0.jar` (the version `main` pins via `apache-lucene
= "10.4.0"`) contains `LuceneTestCase$AwaitsFix`, `$Monster`, `$Nightly` and
`$Weekly` but no `$BadApple`, and the string `badapple` appears nowhere in the
jar.
- No usages in tree. After #5335, `grep -rn "BadApple" --include="*.java"
solr/` returns nothing, and a case-insensitive repo-wide search for `badapple`
matches only historical `CHANGELOG.md` / `changelog/archive.md` entries, which
are left alone.
- Nothing passed `-Ptests.badapples`. No workflow, Gradle script,
`dev-docs/` page or `build.gradle` referenced it; the only callers were the
three `dev-tools/` scripts above, which used `-D` (also honoured, via
`propertyOrDefault`'s `System.properties` fallback) and whose value was
forwarded to the test JVMs where nothing read it.
`./gradlew -p solr/core testOpts` before:
```
tests.awaitsfix = null # Enables or disables @AwaitsFix tests.
tests.badapples = null # Enables or disables @BadApple tests.
```
after:
```
tests.awaitsfix = null # Enables or disables @AwaitsFix tests.
```
The neighbouring `tests.awaitsfix`, `tests.monster`, `tests.weekly` and
`tests.nightly` options all stay; their annotations still exist. Passing
`-Dtests.badapples=false` after this change is simply an unrecognised system
property — Gradle does not reject it, so stale local scripts and muscle memory
keep working.
No changelog entry: dead build configuration with no user-visible effect.
`dev-docs/changelog.adoc` calls an entry a judgement call that is "discouraged"
for minor things, `validate-changelog.yml` only validates entries that are
present, and #5335 merged without one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]