nick-boss-tech opened a new pull request, #5344: URL: https://github.com/apache/solr/pull/5344
# SOLR-18619: use the node proxy for Admin UI reads 🤖 *AI text below* 🤖 *(prepared for review by Nick Shanin)* https://issues.apache.org/jira/browse/SOLR-18619 ## What happens today **Metrics and Nodes still use older proxy parameters.** The Metrics screen uses `node` to select a node. The Nodes view uses `nodes` to collect system information. Other screens, including the log viewer, already use the node picker. ## What this change does **The Admin UI uses `X-Solr-targetNode` for Metrics and system-info requests.** A Solr node can use this header to send a request to another live node. Metrics requests target the selected node. The Nodes view sends a separate request for each node. It keeps successful results and identifies failures. Once the UI knows the local node's cloud identity, generated reads can target that node explicitly. This keeps the selected target stable if a load balancer sends a later request to another node. Standalone reads remain local. The log viewer shows messages from the selected node by default. An **All nodes** option combines messages from live nodes and labels their sources. It reports any nodes that fail. If every request fails, the viewer clears the old messages. Log-level changes keep their existing broadcast behavior. ## Proof **Browser and build verification is pending for this head.** <details> <summary>Verification pending at 855eccb3e7642cc25ce021d64639c5ce82bd3f12</summary> The browser tests cover node targeting, combined logs, failed requests, and standalone behavior. The Admin UI browser workflow and Gradle precommit checks have not run for this head. There is no passing or fail-before result yet. </details> ## A choice to check **We recommend showing the selected node's logs by default.** This follows the node picker. Operators can choose All nodes to troubleshoot the cluster. If cluster-wide logs are more useful as the default, the screen can open on All nodes instead. Does the selected-node default fit the intended navigation? ## Related work **The picker and node proxy are merged. The follow-ups are separate proposals.** | Work | Status and relationship | | --- | --- | | [SOLR-12613 / PR 5110](https://github.com/apache/solr/pull/5110) | Merged: separated cluster and node navigation and added the node picker used here. | | [SOLR-18537 / PR 5112](https://github.com/apache/solr/pull/5112) | Merged: added the header that lets Solr proxy a request to one node. Earlier [SOLR-16738](https://issues.apache.org/jira/browse/SOLR-16738) extended the server's multi-node proxy to V2 APIs. | | SOLR-18619 | This PR: migrates Admin UI reads and adds the log-message view described above. | | [Picker lifecycle follow-up](https://github.com/nick-boss-tech/solr/tree/solr-12613-selection-lifecycle-followup) | Prepared candidate: prevents old selection and refresh responses from replacing the core menu. Its remaining changes need reconciliation with the merged picker. | | [Encoded targeting-key follow-up](https://github.com/nick-boss-tech/solr/tree/solr-18537-encoded-key-followup) | Prepared candidate: fixes encoded query-parameter names in the generic proxy. This PR uses headers and does not depend on that fix. | | [Encoded path coverage follow-up](https://github.com/nick-boss-tech/solr/tree/solr-18537-path-coverage-followup) | Prepared candidate: tests encoded paths across a replica hop. It does not change production behavior. | | [SOLR-15823 / PR 5031](https://github.com/apache/solr/pull/5031) | Open separately: proposes combining logging levels on the server. This PR combines log messages in the browser. The endpoints and approaches differ. | The three prepared follow-ups are not submitted PRs. Their final tickets, branches, and verification remain to be confirmed. ## Limits **This change does not deprecate the old parameters or migrate log-level broadcasts.** The All nodes view makes one request per live node. Changelog: [SOLR-18619-target-node.yml](https://github.com/nick-boss-tech/solr/blob/855eccb3e7642cc25ce021d64639c5ce82bd3f12/changelog/unreleased/SOLR-18619-target-node.yml). *AI-generated description. Nick Shanin directed the work and takes responsibility for this contribution.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
