nick-boss-tech commented on code in PR #5314:
URL: https://github.com/apache/solr/pull/5314#discussion_r4570136842


##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/ClusterStateProviderTest.java:
##########
@@ -216,6 +253,145 @@ public void testGetClusterState() throws Exception {
     }
   }
 
+  @Test
+  @SuppressWarnings("unchecked")
+  public void testSyncWaitsForCallbackAndPropagatesFailure() throws Exception {
+    assumeWorkingMockito();
+    SolrZkClient zkClient = spy(cluster.getZkClient());
+    CuratorFramework curator = mock(CuratorFramework.class);
+    SyncBuilder builder = mock(SyncBuilder.class);

Review Comment:
   🤖 *AI text below* 🤖 *(reviewed by Nick Shanin)*
   
   I removed the sync-specific mock tests along with sync. The remaining mocked 
checks cover collection-read failures, interruption, and the number of lookups 
for a missing input within a request. The real alias test does not cover those 
cases.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to