isaric opened a new pull request, #5345: URL: https://github.com/apache/solr/pull/5345
# Description Test-only fix in SolrJ's `SchemaTest.testMultipleUpdateRequestAccuracy`. The test sends a `MultiUpdate` with an `add-field-type` and two `add-field` commands and then verifies the results, but the second verification block looked up `field1Name` again and asserted `field1Name`, so it never checked that the second `add-field` was applied. Found while answering a question on #5311 (https://github.com/apache/solr/pull/5311#discussion_r4525802374) about whether the server processes both repeated `add-field` keys in one Schema API body; this test was cited there as confirming it, which it only does with this correction. # Solution Point the second lookup and its name assertion at `field2Name`. No production code changes. Too minor for a JIRA or a changelog entry. AI disclosure: the fix and this description were drafted with Claude Code and reviewed by me. # Tests `SchemaTest.testMultipleUpdateRequestAccuracy` passes with the fix and exercises both fields. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. (test-only, minor) - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) - [ ] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change (test-only) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
