github-actions[bot] commented on PR #5347:
URL: https://github.com/apache/solr/pull/5347#issuecomment-6881942394

   **Automated PR readiness judgements** (LLM-generated; may be wrong; not 
updated on later pushes).
   
   - ✅ [Jira issue in 
title](https://github.com/apache/solr/blob/main/CONTRIBUTING.md): already 
present
   - ✅ 
[Changelog](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc#_changelog_types_reference):
 type: added <!-- The PR introduces a new configuration option&#44; 
&#96;solr&#46;​zookeeper&#46;​embedded&#46;​port&#96; &#40;env var 
&#96;SOLR&#95;ZOOKEEPER&#95;EMBEDDED&#95;PORT&#96;&#41;&#44; which is an 
opt&#45;in feature allowing users to explicitly set the embedded ZooKeeper port 
instead of relying on the default &#96;solrPort &#43; 1000&#96;&#46;​ -->
   - ✅ [Reference Guide 
update](https://github.com/apache/solr/tree/main/solr/solr-ref-guide): included 
<!-- The new environment variable 
&#96;SOLR&#95;ZOOKEEPER&#95;EMBEDDED&#95;PORT&#96; and its corresponding system 
property are user&#45;facing configuration options that should be documented in 
the Reference Guide&#44; particularly in sections covering SolrCloud setup and 
embedded ZooKeeper&#46;​ -->
   - ✅ [Upgrade 
notes](https://github.com/apache/solr/tree/main/solr/solr-ref-guide/modules/upgrade-notes/pages):
 not needed <!-- The change is additive&#59; if the new property is not 
set&#44; the behavior remains exactly as before &#40;defaulting to 
&#96;solrPort &#43; 1000&#96;&#41;&#44; so no user action is required for 
existing installations&#46;​ -->
   - ✅ Tests: included <!-- The PR modifies production logic in 
&#96;SolrZkServer&#46;​java&#96; to parse and validate a new port 
configuration&#44; and updates &#96;RunExampleTool&#46;​java&#96; to use this 
new logic&#44; which warrants new tests to verify the precedence&#44; 
validation&#44; and integration with the example tool&#46;​ -->
   
   <!-- Assessed commit c2c3a21f6e4ad002a28f28c5b7b8f7e18525693d -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to