github-actions[bot] commented on PR #5348: URL: https://github.com/apache/solr/pull/5348#issuecomment-6885713119
**Automated PR readiness judgements** (LLM-generated; may be wrong; not updated on later pushes). - ✅ [Jira issue in title](https://github.com/apache/solr/blob/main/CONTRIBUTING.md): already present - ✅ [Changelog](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc#_changelog_types_reference): type: changed <!-- The change modifies the behavior of `bin\solr.cmd` on Windows to write a real PID file and updates `SolrProcessManager` to only read PID files, which is a behavioral change to existing operations (start/stop/status) that users and operators would notice. --> - ⚠️ [Reference Guide update](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) **— missing** (confidence: medium): The PR deprecates the `solr-<port>.port` file and changes how PID files are managed on Windows, which are user-facing behaviors and file artifacts that should be documented in the Reference Guide (e.g., in the section about running Solr or the `solr.in.cmd` configuration). - ✅ [Upgrade notes](https://github.com/apache/solr/tree/main/solr/solr-ref-guide/modules/upgrade-notes/pages): included <!-- The PR explicitly deprecates the `solr-<port>.port` file, stating it will no longer be written in Solr 11.0, and changes the internal logic to ignore `.port` files, which is a backwards-incompatible change for any external scripts relying on the old file format or presence. --> - ⚠️ Tests **— probably not needed**: The changes are primarily to Windows batch scripts (`solr.cmd`, `solr.in.cmd`) and a small internal logic update in `SolrProcessManager` to support the new file format; these are build/CLI tooling changes that do not typically require new unit tests in the Java test suite. <!-- Assessed commit 136300625b16597f19c5244cc04a077810c4ca5d --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
