github-actions[bot] commented on PR #5348:
URL: https://github.com/apache/solr/pull/5348#issuecomment-6885713119

   **Automated PR readiness judgements** (LLM-generated; may be wrong; not 
updated on later pushes).
   
   - ✅ [Jira issue in 
title](https://github.com/apache/solr/blob/main/CONTRIBUTING.md): already 
present
   - ✅ 
[Changelog](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc#_changelog_types_reference):
 type: changed <!-- The change modifies the behavior of 
&#96;bin&#92;solr&#46;​cmd&#96; on Windows to write a real PID file and updates 
&#96;SolrProcessManager&#96; to only read PID files&#44; which is a behavioral 
change to existing operations &#40;start&#47;​stop&#47;​status&#41; that users 
and operators would notice&#46;​ -->
   - ⚠️ [Reference Guide 
update](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) **— 
missing** (confidence: medium): The PR deprecates the 
&#96;solr&#45;&#60;port&#62;&#46;​port&#96; file and changes how PID files are 
managed on Windows&#44; which are user&#45;facing behaviors and file artifacts 
that should be documented in the Reference Guide &#40;e&#46;​g&#46;​&#44; in 
the section about running Solr or the &#96;solr&#46;​in&#46;​cmd&#96; 
configuration&#41;&#46;​
   - ✅ [Upgrade 
notes](https://github.com/apache/solr/tree/main/solr/solr-ref-guide/modules/upgrade-notes/pages):
 included <!-- The PR explicitly deprecates the 
&#96;solr&#45;&#60;port&#62;&#46;​port&#96; file&#44; stating it will no longer 
be written in Solr 11&#46;​0&#44; and changes the internal logic to ignore 
&#96;&#46;​port&#96; files&#44; which is a backwards&#45;incompatible change 
for any external scripts relying on the old file format or presence&#46;​ -->
   - ⚠️ Tests **— probably not needed**: The changes are primarily to Windows 
batch scripts &#40;&#96;solr&#46;​cmd&#96;&#44; 
&#96;solr&#46;​in&#46;​cmd&#96;&#41; and a small internal logic update in 
&#96;SolrProcessManager&#96; to support the new file format&#59; these are 
build&#47;​CLI tooling changes that do not typically require new unit tests in 
the Java test suite&#46;​
   
   <!-- Assessed commit 136300625b16597f19c5244cc04a077810c4ca5d -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to