adityamparikh opened a new pull request, #290:
URL: https://github.com/apache/solr-mcp/pull/290

   ## Summary
   
   Four places give a reason for the client's wire format that isn't true: that 
SolrJ's JavaBin codec "uses deep reflection" and would need extensive 
native-image hints.
   
   ```diff
    SolrConfig.buildSolrClient          // inline comment
    SolrNativeHints                     // class Javadoc
    AGENTS.md                           // "Wire format" bullet
    dev-docs/graalvm-native-image.md    // "Wire format choice underpins the 
small hint surface"
   -  JavaBin needs reflection, so we avoid it
   +  JSON responses + XMLRequestWriter; the native image doesn't require either
   ```
   
   `SolrNativeHints` also called `JsonResponseParser` a SolrJ class (it is this 
project's) and said the XML path is avoided, though every update goes through 
`XMLRequestWriter`.
   
   No code changes; only comments and docs.
   
   ## Evidence
   
   - `JavaBinCodec.java` at `releases/solr/10.0.0` has no `java.lang.reflect`, 
`getDeclared*`, `getMethod`, `Class.forName` or `newInstance`. Its one 
`java.lang.invoke` use is `MethodHandles.lookup()` for the logger. It 
dispatches on `instanceof` and tag bytes, which native-image analysis follows 
without hints.
   - With `JavaBinResponseParser` swapped in for `JsonResponseParser` and no 
hint added, `./gradlew nativeTest -Pnative` passed (0 failed).
   - `./gradlew build`: 460 tests, 0 failures, 0 skipped.
   
   ## Merge Danger
   
   **Door:** two-way
   
   **Blast Radius:** docs
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

  • [PR] docs: correct JavaBin nat... adityamparikh (via GitHub) via issues

Reply via email to