dsmiley commented on code in PR #5350:
URL: https://github.com/apache/solr/pull/5350#discussion_r4580388538
##########
.github/workflows/gradle-extraction-check.yml:
##########
Review Comment:
Should this workflow be removed entirely now since, presumably, the
`solr-test` workflow will run with Docker and run all tests? CC @janhoy
##########
.github/workflows/solr-test.yml:
##########
@@ -1,29 +1,30 @@
-name: SolrJ Tests
+name: Solr Tests
on:
pull_request:
branches:
- '*'
paths:
- - '.github/workflows/solrj-test.yml'
- - 'solr/solrj/**'
+ - '.github/workflows/solr-test.yml'
+ - 'solr/**/src/**'
+ - 'gradle/libs.versions.toml'
concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number ||
github.ref }}
cancel-in-progress: true
jobs:
test:
- name: Run SolrJ Tests
+ name: Run Solr Tests
runs-on: ubuntu-latest
- timeout-minutes: 15
+ timeout-minutes: 45
Review Comment:
I'd rather choose 30 TBH. I guess we'll see how much is needed when the
checks run now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]