tsornin14 commented on code in PR #4921:
URL: https://github.com/apache/solr/pull/4921#discussion_r4585781171


##########
changelog/unreleased/SOLR-18466.yml:
##########
@@ -0,0 +1,8 @@
+title: Support _route_ in the streaming expression function to prune shard 
fan-out

Review Comment:
    Hi Eric,
   
      - **shuffle** — extends `CloudSolrStream` and reuses the same 
`constructStreams()` path without overriding it.
   
      - **random, knn, facet, stats, timeseries, facet2D** — these forward all 
their params in a single request to `CloudSolrClient`, and the server applies 
`_route_` natively.
   
      - **topic, train, features, significantTerms** — left as-is, and should 
not be pruned.
   
      - **drill** — this is a gap; let me know your thoughts on adding it to 
this or submitting a separate PR. `DrillStream` extends `CloudSolrStream` and 
overrides `constructStreams()`, building a `new ModifiableSolrParams()` from 
scratch — copying `_route_` if it exists would be the change.
   
      Thanks,
      Mathew



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to