isaric opened a new pull request, #5351:
URL: https://github.com/apache/solr/pull/5351

   # Description
   
   `main` fails `./gradlew check` (and any test task) since #5268, for two 
reasons:
   
   1. **Dependency lock state.** #5268 added 
`org.testcontainers:testcontainers` to `solr/test-framework` as an 
`implementation` dependency without re-running the lock task. Every module that 
depends on test-framework now fails resolution with `Resolved 
'org.testcontainers:testcontainers:2.0.5' which is not part of the dependency 
lock state` (and the same for its transitive dependencies, plus libraries such 
as commons-lang3 that moved onto the compile classpath).
   2. **Logging validation.** The new `TestcontainersUtil` logs `e.toString()` 
inside a `log.info(...)` call, which `validateLogCalls` rejects because the 
string is built even when INFO is disabled.
   
   #5268's Gradle Precommit run reported both before it was merged.
   
   # Solution
   
   Two commits, no functional change:
   
   - Regenerated the lock files with `./gradlew resolveAndLockAll 
--write-locks` (22 files, additions only, no version changes to anything 
already pinned).
   - Wrapped the one logging call in `if (log.isInfoEnabled())`, the pattern 
the validator asks for.
   
   No JIRA: build hygiene. No changelog entry.
   
   AI disclosure: the diagnosis and this description were drafted with Claude 
Code and reviewed by me.
   
   # Tests
   
   `./gradlew check -x test` passes on `main` with these two commits (it fails 
on `main` without them). No test changes.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to 
Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my 
code conforms to the standards described there to the best of my ability.
   - [ ] I have created a Jira issue and added the issue ID to my pull request 
title. (build fix, no JIRA)
   - [x] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended, not available for 
branches on forks living under an organisation)
   - [x] I have developed this patch against the `main` branch.
   - [x] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference 
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   - [ ] I have added a [changelog 
entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my 
change (build fix)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to