danielmeint commented on code in PR #827:
URL: https://github.com/apache/solr-operator/pull/827#discussion_r4620859420


##########
controllers/util/solr_security_util.go:
##########
@@ -520,7 +527,11 @@ func useSecureProbe(solrCloud *solr.SolrCloud, probe 
*corev1.Probe, mountPath st
                javaToolOptionsOutputFilter = ""
        }
 
-       probeCommand := fmt.Sprintf("%ssolr api -get 
\"%s://${SOLR_HOST}:%d%s\"%s", javaToolOptionsStr, solrCloud.UrlScheme(false), 
probe.HTTPGet.Port.IntVal, probe.HTTPGet.Path, javaToolOptionsOutputFilter)
+       apiUrlFlag := "--solr-url"
+       if solrCloud.SolrVersionBelow("9.7") {
+               apiUrlFlag = "-get"
+       }
+       probeCommand := fmt.Sprintf("%ssolr api %s 
\"%s://${SOLR_HOST}:%d%s\"%s", javaToolOptionsStr, apiUrlFlag, 
solrCloud.UrlScheme(false), probe.HTTPGet.Port.IntVal, probe.HTTPGet.Path, 
javaToolOptionsOutputFilter)

Review Comment:
   This isn't specific to Solr 10. The Solr 9 probe has always piped through 
the same filter. It's fixed in #854, which builds on this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to