liangkaiwen commented on PR #4935: URL: https://github.com/apache/solr/pull/4935#issuecomment-6992832166
> Thinking a little bit more about this, my opinion: (not a hard position) I believe we could get rid of one of the two parameters (preload, preloadExtensions) and just use one: potentially 'preload' is enough, but it will behave differently: no boolean anymore ALL_FILES -> equivalent to true -> preload those extensions, with priority (if supported) not passing the parameter implies no preload. > > I suspect this can be cleaner and equally effective/readable. What do you think? I am a big fan of not having both params, however I went this way for backwards compatibility. I assume that backwards incompatible changes are left for major versions, however if you feel that this is something you would support shipping I am more than happy to re-write this to get rid of the unnecessary boolean param. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
