Neta-Rose commented on PR #5359: URL: https://github.com/apache/solr/pull/5359#issuecomment-7008334951
Thanks, @sarkaramrit1993 good catch: cancelPrepRecoveryCmd() interrupts the recovery thread itself, so the guard skipped the main case. Removing it alone wasn't enough when the buffer tlog has data (closing it on the interrupted thread throws ClosedByInterruptException), so the drop now clears the interrupt flag and restores it afterwards. I added a test for this (PREPRECOVERY paused, buffered updates, cancel from another thread). It fails on the previous commit and passes now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
