HoustonPutman commented on code in PR #722:
URL: https://github.com/apache/solr-operator/pull/722#discussion_r4632450407


##########
controllers/solrcloud_controller.go:
##########
@@ -725,6 +748,8 @@ func (r *SolrCloudReconciler) Reconcile(ctx 
context.Context, req ctrl.Request) (
                return requeueOrNot, serviceCleanupError
        }
 
+       updateObservedGeneration = false
+       newStatus.ObservedGeneration = &reconcileGeneration

Review Comment:
   Also shouldn't we be waiting to make sure there are no running or queued 
Cluster Operations?



##########
controllers/solrcloud_controller.go:
##########
@@ -134,6 +136,27 @@ func (r *SolrCloudReconciler) Reconcile(ctx 
context.Context, req ctrl.Request) (
        requeueOrNot := reconcile.Result{}
 
        newStatus := solrv1beta1.SolrCloudStatus{}
+       updateObservedGeneration := true
+
+       // Update the observed generation if reconcile exits early due to an 
error, indicating no further progress can be made.
+       // It simply indicates that the operator has tried all possible actions.

Review Comment:
   I'm quite confused here, why are we updating the generation if there's an 
error. The error can very much mean that we can't make the user's expected 
state of Solr actually happen. So why would we say the generation is what the 
user expects?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to