nick-boss-tech commented on code in PR #5301:
URL: https://github.com/apache/solr/pull/5301#discussion_r4636521365


##########
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ConnectionManager.java:
##########
@@ -31,7 +32,7 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-public class ConnectionManager implements Watcher {
+public class ConnectionManager {

Review Comment:
   🤖 *AI text below* 🤖
   
   Is removing `Watcher` and `process(WatchedEvent)` intentional for the 9.x 
backport? Both are in the [published 9.x Java 
API](https://solr.apache.org/docs/9_6_0/solrj-zookeeper/org/apache/solr/common/cloud/ConnectionManager.html).
 Moving Solr’s own registration to `SessionWatcher` makes sense; I’d check 
whether we should keep the old public surface for external callers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to