janhoy commented on code in PR #4893:
URL: https://github.com/apache/solr/pull/4893#discussion_r4642551211


##########
solr/packaging/test/test_start_solr.bats:
##########
@@ -88,6 +88,13 @@ teardown() {
   assert_file_contains "${SOLR_LOGS_DIR}/solr.log" 'Deprecated system property 
disable.config.edit has been replaced by solr.api.config.edit.enabled'
 }
 
+@test "solr.xml referencing a deprecated system property logs a deprecation 
warning" {

Review Comment:
   🤖 This PR adds *solr.xml referencing a deprecated system property logs a 
deprecation warning* to `test_start_solr.bats`. BATS is going away: CATS 
(SOLR-18642, #5323) has replaced it on `main`, and SOLR-18645 (#5369) removes 
the `.bats` files. Please port it to `StartSolrTest` in 
`solr/packaging/src/test/org/apache/solr/shell/`, next to the existing 
`disable.config.edit` deprecation-log test. See 
[dev-docs/cats.adoc](https://github.com/apache/solr/blob/main/dev-docs/cats.adoc)
 for porting help.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to