github-actions[bot] commented on PR #5376: URL: https://github.com/apache/solr/pull/5376#issuecomment-7071526555
**Automated PR readiness judgements** (LLM-generated; may be wrong; not updated on later pushes). ⚠️ Prefer PRs against `main`. This PR targets branch_10x. - ✅ [Jira issue in title](https://github.com/apache/solr/blob/main/CONTRIBUTING.md): already present - ✅ [Changelog](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc#_changelog_types_reference): type: fixed <!-- The change fixes a bug where errors from a failed merged update stream were recorded against only one request, leading to incorrect retry behavior and error reporting. The changelog entry explicitly notes a user-visible side effect regarding non-idempotent updates being applied twice on retry, which is a significant behavioral correction. --> - ✅ [Reference Guide update](https://github.com/apache/solr/tree/main/solr/solr-ref-guide): not needed <!-- This is an internal fix to how errors are attributed in the distributed update mechanism. It does not introduce new configuration options, API parameters, or user-facing behaviors that require documentation in the Reference Guide. --> - ✅ [Upgrade notes](https://github.com/apache/solr/tree/main/solr/solr-ref-guide/modules/upgrade-notes/pages): not needed <!-- The change is a bug fix that corrects error attribution. While it changes the behavior of retries (potentially causing double-application of non-idempotent updates that were previously incorrectly retried or not retried), it does not remove or rename any API, parameter, or configuration element, nor does it change a default in a way that requires user action to upgrade. --> - ✅ Tests: included <!-- The PR modifies non-trivial production logic in `StreamingSolrClients`, `ConcurrentUpdateBaseSolrClient`, and `SolrCmdDistributor` to track and attribute errors per request in a stream. This complex state management and error handling logic requires tests to verify correct behavior, as indicated by the mention of specific test classes in the description. --> <!-- Assessed commit 1e0cb9459c528032e3dc3275587ec123b1fc28c9 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
