[
https://issues.apache.org/jira/browse/SPARK-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979383#comment-13979383
]
Sean Owen commented on SPARK-1590:
----------------------------------
I love static analysis, and like FindBugs. I've submitted a few changes already
that follow from static analysis. Over time I hope a lot more small fixes from
inspections can be incorporated.
In general I find that IntelliJ's inspections are much better than FindBugs.
And for Scala, IntelliJ already has a decent set of Scala inspections, whereas
FindBugs isn't quite set up to make sense of Scala.
I also find that incorporating static analysis into the build, which inevitably
means trying to warn or fail on builds with a new 'error', doesn't work. Too
many false positives.
Therefore I suggest that there's not a particular action here, other than the
idea that, when the dust settles from 1.0.0, we should run static analysis
tools -- probably IntelliJ's really -- and submit patches that fix existing
non-trivial issues. And repeat that process periodically.
> Recommend to use FindBugs
> -------------------------
>
> Key: SPARK-1590
> URL: https://issues.apache.org/jira/browse/SPARK-1590
> Project: Spark
> Issue Type: Question
> Components: Build
> Reporter: Shixiong Zhu
> Priority: Minor
> Attachments: findbugs.png
>
>
> FindBugs is an open source program created by Bill Pugh and David Hovemeyer
> which looks for bugs in Java code. It uses static analysis to identify
> hundreds of different potential types of errors in Java programs.
> Although Spark is a Scala project, FindBugs is still helpful. For example, I
> used it to find SPARK-1583 and SPARK-1589. However, the disadvantage is that
> the report generated by FindBugs usually contains many false alarms for a
> Scala project.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
