[ https://issues.apache.org/jira/browse/SPARK-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14040983#comment-14040983 ]
Andrew Ash commented on SPARK-1846: ----------------------------------- Yep this was merged in commit 3abe2b734a5578966f671c34f1de34b4446b90f1 for master and aa5f989a537ec616b30ce8f7e134959eb1bbdc11 for branch-1.0 Good to close > RAT checks should exclude logs/ directory > ----------------------------------------- > > Key: SPARK-1846 > URL: https://issues.apache.org/jira/browse/SPARK-1846 > Project: Spark > Issue Type: Bug > Components: Build > Affects Versions: 1.0.0 > Reporter: Andrew Ash > Fix For: 1.0.0 > > > When there are logs in the logs/ directory, the rat check from > ./dev/check-license fails. > ``` > aash@aash-mbp ~/git/spark$ find logs -type f > logs/spark-aash-org.apache.spark.deploy.master.Master-1-aash-mbp.local.out > logs/spark-aash-org.apache.spark.deploy.master.Master-1-aash-mbp.local.out.1 > logs/spark-aash-org.apache.spark.deploy.master.Master-1-aash-mbp.local.out.2 > logs/spark-aash-org.apache.spark.deploy.master.Master-1-aash-mbp.local.out.3 > logs/spark-aash-org.apache.spark.deploy.master.Master-1-aash-mbp.local.out.4 > logs/spark-aash-org.apache.spark.deploy.master.Master-1-aash-mbp.local.out.5 > logs/spark-aash-org.apache.spark.deploy.worker.Worker--aash-mbp.local.out > logs/spark-aash-org.apache.spark.deploy.worker.Worker--aash-mbp.local.out.1 > logs/spark-aash-org.apache.spark.deploy.worker.Worker-1-aash-mbp.local.out > logs/spark-aash-org.apache.spark.deploy.worker.Worker-1-aash-mbp.local.out.1 > logs/spark-aash-org.apache.spark.deploy.worker.Worker-1-aash-mbp.local.out.2 > logs/spark-aash-org.apache.spark.deploy.worker.Worker-1-aash-mbp.local.out.3 > logs/spark-aash-org.apache.spark.deploy.worker.Worker-1-aash-mbp.local.out.4 > logs/spark-aash-org.apache.spark.deploy.worker.Worker-1-aash-mbp.local.out.5 > logs/spark-aash-spark.deploy.master.Master-1-aash-mbp.local.out > logs/spark-aash-spark.deploy.master.Master-1-aash-mbp.local.out.1 > logs/spark-aash-spark.deploy.master.Master-1-aash-mbp.local.out.2 > logs/spark-aash-spark.deploy.worker.Worker-1-aash-mbp.local.out > logs/spark-aash-spark.deploy.worker.Worker-1-aash-mbp.local.out.1 > logs/spark-aash-spark.deploy.worker.Worker-1-aash-mbp.local.out.2 > aash@aash-mbp ~/git/spark$ ./dev/check-license > Could not find Apache license headers in the following files: > !????? > /Users/aash/git/spark/logs/spark-aash-org.apache.spark.deploy.master.Master-1-aash-mbp.local.out > !????? > /Users/aash/git/spark/logs/spark-aash-org.apache.spark.deploy.master.Master-1-aash-mbp.local.out.1 > !????? > /Users/aash/git/spark/logs/spark-aash-org.apache.spark.deploy.master.Master-1-aash-mbp.local.out.2 > !????? > /Users/aash/git/spark/logs/spark-aash-org.apache.spark.deploy.master.Master-1-aash-mbp.local.out.3 > !????? > /Users/aash/git/spark/logs/spark-aash-org.apache.spark.deploy.master.Master-1-aash-mbp.local.out.4 > !????? > /Users/aash/git/spark/logs/spark-aash-org.apache.spark.deploy.master.Master-1-aash-mbp.local.out.5 > !????? > /Users/aash/git/spark/logs/spark-aash-org.apache.spark.deploy.worker.Worker--aash-mbp.local.out > !????? > /Users/aash/git/spark/logs/spark-aash-org.apache.spark.deploy.worker.Worker--aash-mbp.local.out.1 > !????? > /Users/aash/git/spark/logs/spark-aash-org.apache.spark.deploy.worker.Worker-1-aash-mbp.local.out > !????? > /Users/aash/git/spark/logs/spark-aash-org.apache.spark.deploy.worker.Worker-1-aash-mbp.local.out.1 > !????? > /Users/aash/git/spark/logs/spark-aash-org.apache.spark.deploy.worker.Worker-1-aash-mbp.local.out.2 > !????? > /Users/aash/git/spark/logs/spark-aash-org.apache.spark.deploy.worker.Worker-1-aash-mbp.local.out.3 > !????? > /Users/aash/git/spark/logs/spark-aash-org.apache.spark.deploy.worker.Worker-1-aash-mbp.local.out.4 > !????? > /Users/aash/git/spark/logs/spark-aash-org.apache.spark.deploy.worker.Worker-1-aash-mbp.local.out.5 > !????? > /Users/aash/git/spark/logs/spark-aash-spark.deploy.master.Master-1-aash-mbp.local.out > !????? > /Users/aash/git/spark/logs/spark-aash-spark.deploy.master.Master-1-aash-mbp.local.out.1 > !????? > /Users/aash/git/spark/logs/spark-aash-spark.deploy.master.Master-1-aash-mbp.local.out.2 > !????? > /Users/aash/git/spark/logs/spark-aash-spark.deploy.worker.Worker-1-aash-mbp.local.out > !????? > /Users/aash/git/spark/logs/spark-aash-spark.deploy.worker.Worker-1-aash-mbp.local.out.1 > !????? > /Users/aash/git/spark/logs/spark-aash-spark.deploy.worker.Worker-1-aash-mbp.local.out.2 > aash@aash-mbp ~/git/spark$ > ``` -- This message was sent by Atlassian JIRA (v6.2#6252)