[ 
https://issues.apache.org/jira/browse/SPARK-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14068293#comment-14068293
 ] 

Sean Owen commented on SPARK-2599:
----------------------------------

The problem I see with this is that it treats epsilon as both absolute and 
relative. You can imagine this leads to some weird situations. For example, how 
do I test for 0.005 +/- 100%? If I set epsilon to 1.0, I'll accept 0.005 +/- 
1.0, which is far too large.

> almostEquals mllib.util.TestingUtils does not behave as expected when 
> comparing against 0.0
> -------------------------------------------------------------------------------------------
>
>                 Key: SPARK-2599
>                 URL: https://issues.apache.org/jira/browse/SPARK-2599
>             Project: Spark
>          Issue Type: Bug
>          Components: MLlib
>            Reporter: Doris Xin
>            Priority: Minor
>
> DoubleWithAlmostEquals.almostEquals, when used to compare a number with 0.0, 
> would always produce an epsilon of 1 >> 1e-10, causing false failure when 
> comparing very small numbers with 0.0.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to