[
https://issues.apache.org/jira/browse/SPARK-14627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240712#comment-15240712
]
Apache Spark commented on SPARK-14627:
--------------------------------------
User 'viirya' has created a pull request for this issue:
https://github.com/apache/spark/pull/12387
> In TypedAggregateExpression update method we call encoder.shift many times
> --------------------------------------------------------------------------
>
> Key: SPARK-14627
> URL: https://issues.apache.org/jira/browse/SPARK-14627
> Project: Spark
> Issue Type: Improvement
> Reporter: Liang-Chi Hsieh
> Priority: Minor
>
> Every time we call TypedAggregateExpression.update method, we call encoder's
> shift method. As shift method will copy encoder and underlying
> BoundReference, we should prepare the shifted encoder in advance, instead of
> calling shift method every time.
> BTW, we can also improve encoder's shift method to return itself when shift
> delta is zero.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
