[ 
https://issues.apache.org/jira/browse/SPARK-15100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289513#comment-15289513
 ] 

Gayathri Murali edited comment on SPARK-15100 at 5/18/16 6:25 PM:
------------------------------------------------------------------

While making changes to CountVectorizer, HashingTF and QuantileDiscretizer I 
found the following issues

1. RelativeError is not available in Python for Quantile Discretizer. 
2. Inbuilt Python examples in feature.py does not include the newly added 
binary toggle parameter in both HashingTF and CountVectorizer
3. I am making changes to the example source code to include these parameters 
so that it reflects in the user doc. I hope this is expected

For 1 and 2, Should I send out a separate PR?


was (Author: gayathrimurali):
While making changes to CountVectorizer, HashingTF and QuantileDiscretizer I 
found the following issues

1. RelativeError is not available in Python for Quantile Discretizer. 
2. In built Python examples in feature.py does not include the newly added 
parameters such as Binary or relative Error
3. I am making changes to the example source code to include these parameters 
in model building. I hope this is expected

For 1 and 2, Should I send out a separate PR?

> Audit: ml.feature
> -----------------
>
>                 Key: SPARK-15100
>                 URL: https://issues.apache.org/jira/browse/SPARK-15100
>             Project: Spark
>          Issue Type: Documentation
>          Components: Documentation, ML
>            Reporter: Joseph K. Bradley
>
> Audit this sub-package for new algorithms which do not have corresponding 
> sections & examples in the user guide.
> See parent issue for more details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to