[ https://issues.apache.org/jira/browse/SPARK-15363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15292403#comment-15292403 ]
Xiangrui Meng commented on SPARK-15363: --------------------------------------- No. I think we need to make the converters between new and old vectors public (WIP) and then in example code, we don't need implicits. Another option is to make implicits public. > Example code shouldn't use VectorImplicits._, asML/fromML > --------------------------------------------------------- > > Key: SPARK-15363 > URL: https://issues.apache.org/jira/browse/SPARK-15363 > Project: Spark > Issue Type: Improvement > Components: Documentation, ML > Reporter: Xiangrui Meng > > In SPARK-14615, we use VectorImplicits._ and asML in example code to > minimize the changes in that PR. However, this is a private API, which > shouldn't appear in the example code. We should consider update them during > QA. > https://github.com/dbtsai/spark/blob/9d25ebacfb4abf4d80d5f6815fac920d18347799/examples/src/main/scala/org/apache/spark/examples/ml/DataFrameExample.scala -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org