[
https://issues.apache.org/jira/browse/SPARK-16485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375725#comment-15375725
]
Joseph K. Bradley commented on SPARK-16485:
-------------------------------------------
Will fix:
* GeneralizedLinearRegressionModel: linkObj, familyObj, familyAndLink should
not be exposed
* sqlDataTypes: name does not follow conventions. Do we need to expose it?
* Evaluator: inconsistent doc between evaluate and isLargerBetter
* MinMaxScaler: math rendering --> hard to make it great, but I'll change it a
little
* GeneralizedLinearRegressionSummary: aic doc is incorrect --> will change to
use more common name
Won't change:
* GBTClassificationModel, RandomForestClassificationModel --> no need to
override setters for Params which do not affect Model behavior.
* LogisticRegressionModel: setThreshold(s) --> looks OK in JAR
* MultivariateGaussian
> Additional fixes to Mllib 2.0 documentation
> -------------------------------------------
>
> Key: SPARK-16485
> URL: https://issues.apache.org/jira/browse/SPARK-16485
> Project: Spark
> Issue Type: Sub-task
> Components: Documentation, GraphX, ML, MLlib, SparkR
> Reporter: Timothy Hunter
> Assignee: Joseph K. Bradley
>
> While reviewing the documentation of MLlib, I found some additional issues.
> Important issues that affect the binary signatures:
> - GBTClassificationModel: all the setters should be overriden
> - LogisticRegressionModel: setThreshold(s)
> - RandomForestClassificationModel: all the setters should be overriden
> - org.apache.spark.ml.stat.distribution.MultivariateGaussian is exposed but
> most of the methods are private[ml] -> do we need to expose this class for
> now?
> - GeneralizedLinearRegressionModel: linkObj, familyObj, familyAndLink should
> not be exposed
> - sqlDataTypes: name does not follow conventions. Do we need to expose it?
> Issues that involve only documentation:
> - Evaluator:
> 1. inconsistent doc between evaluate and isLargerBetter
> - MinMaxScaler: math rendering
> - GeneralizedLinearRegressionSummary: aic doc is incorrect
> The reference documentation that was used was:
> http://people.apache.org/~pwendell/spark-releases/spark-2.0.0-rc2-docs/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
