Jiang Xingbo created SPARK-17506:
------------------------------------

             Summary: Improve the check double values equality rule
                 Key: SPARK-17506
                 URL: https://issues.apache.org/jira/browse/SPARK-17506
             Project: Spark
          Issue Type: Improvement
          Components: SQL
            Reporter: Jiang Xingbo
            Priority: Critical


In `ExpressionEvalHelper`, we check the equality between two double values by 
comparing whether the expected value is within the range [target - tolerance, 
target + tolerance], but this can cause a negative false when the compared 
numerics are very large. 
For example:
{code}
val1 = 1.6358558070241E306
val2 = 1.6358558070240974E306
ExpressionEvalHelper.compareResults(val1, val2)
false
{code}
In fact, val1 and val2 are but with different precisions, we should tolerant 
this case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to