[ https://issues.apache.org/jira/browse/SPARK-17789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15550607#comment-15550607 ]
DB Tsai commented on SPARK-17789: --------------------------------- I have comment on the code. When the initial model is set, the k should be set to the # of centers in the initial model. > Don't force users to set k for KMeans if initial model is set > ------------------------------------------------------------- > > Key: SPARK-17789 > URL: https://issues.apache.org/jira/browse/SPARK-17789 > Project: Spark > Issue Type: Improvement > Components: ML > Reporter: Seth Hendrickson > Priority: Minor > > In the initial implementation of initalModel, we allow users to set the > initial model with a KMeansModel that has a different {{k}} than the current > model. We throw an error at train time if the two are mismatched. This means > that the following code throws a runtime exception: > {code} > val kmeansModel = new KMeans().setInitialModel(model).fit(df) > {code} > We should discuss this behavior, and decide if we should enforce users to set > both the initial model and k, or if we should alter k when the initial model > is set, or if we should keep the current behavior. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org