[ https://issues.apache.org/jira/browse/SPARK-17944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15577826#comment-15577826 ]
Sean Owen commented on SPARK-17944: ----------------------------------- Yes, for example `hostname` differs on OS X / Linux but the behavior of `-f` happens to give the same desired output on both. Is `check-hostname` present only on Solaris (or at least, does it do the right thing everywhere we think it exists)? If so I could imagine just checking if that command exists and using it if present. There are 3 usages, and all could have the same treatment. That's not so bad IMHO. A central script to switch out commands seems appealing but the indirection non-trivially complicates the scripts. I'm not sure how far to go to try to support Solaris, not because there's anything wrong with it, but because a) I don't know how many Spark users are on Solaris, and b) I am not sure we know it otherwise works, that there aren't other problems like this > sbin/start-* scripts use of `hostname -f` fail with Solaris > ------------------------------------------------------------ > > Key: SPARK-17944 > URL: https://issues.apache.org/jira/browse/SPARK-17944 > Project: Spark > Issue Type: Bug > Affects Versions: 2.0.1 > Environment: Solaris 10, Solaris 11 > Reporter: Erik O'Shaughnessy > Priority: Trivial > > {{$SPARK_HOME/sbin/start-master.sh}} fails: > {noformat} > $ ./start-master.sh > usage: hostname [[-t] system_name] > hostname [-D] > starting org.apache.spark.deploy.master.Master, logging to > /home/eoshaugh/local/spark/logs/spark-eoshaugh-org.apache.spark.deploy.master.Master-1-m7-16-002-ld1.out > failed to launch org.apache.spark.deploy.master.Master: > --properties-file FILE Path to a custom Spark properties file. > Default is conf/spark-defaults.conf. > full log in > /home/eoshaugh/local/spark/logs/spark-eoshaugh-org.apache.spark.deploy.master.Master-1-m7-16-002-ld1.out > {noformat} > I found SPARK-17546 which changed the invocation of hostname in > sbin/start-master.sh, sbin/start-slaves.sh and sbin/start-mesos-dispatcher.sh > to include the flag {{-f}}, which is not a valid command line option for the > Solaris hostname implementation. > As a workaround, Solaris users can substitute: > {noformat} > `/usr/sbin/check-hostname | awk '{print $NF}'` > {noformat} > Admittedly not an obvious fix, but it provides equivalent functionality. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org