[ 
https://issues.apache.org/jira/browse/SPARK-18374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15650799#comment-15650799
 ] 

Sean Owen commented on SPARK-18374:
-----------------------------------

I think the idea is that it's applied post-tokenization, after which "won't" 
becomes "won" and "t". Removing them would cause a different perhaps bigger 
problem. It does seem more ideal to not split "won't" of course and maybe 
that's a way forward, but I'm not sure how to do that reliably in a 
language-agnostic way without implementing a lot more sophisticated logic.

> Incorrect words in StopWords/english.txt
> ----------------------------------------
>
>                 Key: SPARK-18374
>                 URL: https://issues.apache.org/jira/browse/SPARK-18374
>             Project: Spark
>          Issue Type: Bug
>          Components: ML
>    Affects Versions: 2.0.1
>            Reporter: nirav patel
>
> I was just double checking english.txt for list of stopwords as I felt it was 
> taking out valid tokens like 'won'. I think issue is english.txt list is 
> missing apostrophe character and all character after apostrophe. So "won't" 
> becam "won" in that list; "wouldn't" is "wouldn" .
> Here are some incorrect tokens in this list:
> won
> wouldn
> ma
> mightn
> mustn
> needn
> shan
> shouldn
> wasn
> weren
> I think ideal list should have both style. i.e. won't and wont both should be 
> part of english.txt as some tokenizer might remove special characters. But 
> 'won' is obviously shouldn't be in this list.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to