[
https://issues.apache.org/jira/browse/SPARK-18420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
coneyliu updated SPARK-18420:
-----------------------------
Description:
What changes were proposed in this pull request?
Small fix, fix the errors caused by lint check in Java
Clear unused objects and UnusedImports.
Add suppression rules for the method finalize of NioBufferedFileInputStream.
Cut the line which is longer than 100 characters into two lines.
How was this patch tested?
Travis CI.
$ build/mvn -T 4 -q -DskipTests -Pyarn -Phadoop-2.3 -Pkinesis-asl -Phive
-Phive-thriftserver install
$ dev/lint-java
Before:
Checkstyle checks failed at following occurrences:
[ERROR] src/main/java/org/apache/spark/network/util/TransportConf.java:[21,8]
(imports) UnusedImports: Unused import -
org.apache.commons.crypto.cipher.CryptoCipherFactory.
[ERROR] src/test/java/org/apache/spark/network/sasl/SparkSaslSuite.java:[516,5]
(modifier) RedundantModifier: Redundant 'public' modifier.
[ERROR] src/main/java/org/apache/spark/io/NioBufferedFileInputStream.java:[133]
(coding) NoFinalizer: Avoid using finalizer method.
[ERROR]
src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeMapData.java:[71]
(sizes) LineLength: Line is longer than 100 characters (found 113).
[ERROR]
src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java:[112]
(sizes) LineLength: Line is longer than 100 characters (found 110).
[ERROR]
src/test/java/org/apache/spark/sql/catalyst/expressions/HiveHasherSuite.java:[31,17]
(modifier) ModifierOrder: 'static' modifier out of order with the JLS
suggestions.
[ERROR]src/main/java/org/apache/spark/examples/ml/JavaLogisticRegressionWithElasticNetExample.java:[64]
(sizes) LineLength: Line is longer than 100 characters (found 103).
[ERROR]
src/main/java/org/apache/spark/examples/ml/JavaInteractionExample.java:[22,8]
(imports) UnusedImports: Unused import - org.apache.spark.ml.linalg.Vectors.
[ERROR]
src/main/java/org/apache/spark/examples/ml/JavaInteractionExample.java:[51]
(regexp) RegexpSingleline: No trailing whitespace allowed.
After:
$ build/mvn -T 4 -q -DskipTests -Pyarn -Phadoop-2.3 -Pkinesis-asl -Phive
-Phive-thriftserver install
$ dev/lint-java
Using `mvn` from path:
/home/travis/build/ConeyLiu/spark/build/apache-maven-3.3.9/bin/mvn
Checkstyle checks passed.
was:
Small fix, fix the compile errors caused by checkstyle.
Before:
```
Checkstyle checks failed at following occurrences:
[ERROR] src/main/java/org/apache/spark/network/util/TransportConf.java:[21,8]
(imports) UnusedImports: Unused import -
org.apache.commons.crypto.cipher.CryptoCipherFactory.
[ERROR] src/test/java/org/apache/spark/network/sasl/SparkSaslSuite.java:[516,5]
(modifier) RedundantModifier: Redundant 'public' modifier.
[ERROR]
src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeMapData.java:[71]
(sizes) LineLength: Line is longer than 100 characters (found 113).
[ERROR]
src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java:[112]
(sizes) LineLength: Line is longer than 100 characters (found 110).
src/main/java/org/apache/spark/examples/ml/JavaLogisticRegressionWithElasticNetExample.java:[64]
(sizes) LineLength: Line is longer than 100 characters (found 103).
[ERROR]
src/main/java/org/apache/spark/examples/ml/JavaInteractionExample.java:[22,8]
(imports) UnusedImports: Unused import - org.apache.spark.ml.linalg.Vectors.
[ERROR]
src/main/java/org/apache/spark/examples/ml/JavaInteractionExample.java:[51]
(regexp) RegexpSingleline: No trailing whitespace allowed.
```
After:
`mvn install`
`lint-java`
Checkstyle checks passed
> Fix the compile errors caused by checkstyle
> -------------------------------------------
>
> Key: SPARK-18420
> URL: https://issues.apache.org/jira/browse/SPARK-18420
> Project: Spark
> Issue Type: Improvement
> Components: Build
> Affects Versions: 2.0.1
> Reporter: coneyliu
> Priority: Minor
>
> What changes were proposed in this pull request?
> Small fix, fix the errors caused by lint check in Java
> Clear unused objects and UnusedImports.
> Add suppression rules for the method finalize of NioBufferedFileInputStream.
> Cut the line which is longer than 100 characters into two lines.
> How was this patch tested?
> Travis CI.
> $ build/mvn -T 4 -q -DskipTests -Pyarn -Phadoop-2.3 -Pkinesis-asl -Phive
> -Phive-thriftserver install
> $ dev/lint-java
> Before:
> Checkstyle checks failed at following occurrences:
> [ERROR] src/main/java/org/apache/spark/network/util/TransportConf.java:[21,8]
> (imports) UnusedImports: Unused import -
> org.apache.commons.crypto.cipher.CryptoCipherFactory.
> [ERROR]
> src/test/java/org/apache/spark/network/sasl/SparkSaslSuite.java:[516,5]
> (modifier) RedundantModifier: Redundant 'public' modifier.
> [ERROR]
> src/main/java/org/apache/spark/io/NioBufferedFileInputStream.java:[133]
> (coding) NoFinalizer: Avoid using finalizer method.
> [ERROR]
> src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeMapData.java:[71]
> (sizes) LineLength: Line is longer than 100 characters (found 113).
> [ERROR]
> src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java:[112]
> (sizes) LineLength: Line is longer than 100 characters (found 110).
> [ERROR]
> src/test/java/org/apache/spark/sql/catalyst/expressions/HiveHasherSuite.java:[31,17]
> (modifier) ModifierOrder: 'static' modifier out of order with the JLS
> suggestions.
> [ERROR]src/main/java/org/apache/spark/examples/ml/JavaLogisticRegressionWithElasticNetExample.java:[64]
> (sizes) LineLength: Line is longer than 100 characters (found 103).
> [ERROR]
> src/main/java/org/apache/spark/examples/ml/JavaInteractionExample.java:[22,8]
> (imports) UnusedImports: Unused import - org.apache.spark.ml.linalg.Vectors.
> [ERROR]
> src/main/java/org/apache/spark/examples/ml/JavaInteractionExample.java:[51]
> (regexp) RegexpSingleline: No trailing whitespace allowed.
> After:
> $ build/mvn -T 4 -q -DskipTests -Pyarn -Phadoop-2.3 -Pkinesis-asl -Phive
> -Phive-thriftserver install
> $ dev/lint-java
> Using `mvn` from path:
> /home/travis/build/ConeyLiu/spark/build/apache-maven-3.3.9/bin/mvn
> Checkstyle checks passed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
