[ 
https://issues.apache.org/jira/browse/SPARK-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15820529#comment-15820529
 ] 

Maciej Szymkiewicz commented on SPARK-19164:
--------------------------------------------

[~rxin] I am particularly interested in {{\_broadcast}} and destructor 
{{\_\_del\_\_}}. Both have been added with SPARK-5752. but it doesn't seem to 
be covered by any tests, it is not used internally by the 
{{UserDefinedFunction}} nor any other part of the code from this PR. Is there 
any reason for it to exist or is it just a dead code that can be safely removed?

> Review of UserDefinedFunction._broadcast
> ----------------------------------------
>
>                 Key: SPARK-19164
>                 URL: https://issues.apache.org/jira/browse/SPARK-19164
>             Project: Spark
>          Issue Type: Sub-task
>          Components: PySpark, SQL
>    Affects Versions: 1.6.0, 2.0.0, 2.1.0, 2.2.0
>            Reporter: Maciej Szymkiewicz
>
> It doesn't look like {{UserDefinedFunction._broadcast}} is used at all. If 
> this is a valid observation it could be remove with corresponding 
> {{\_\_del\_\_}} method. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to